This repository was archived by the owner on Oct 25, 2023. It is now read-only.
restructure all StorageApi methods to have 1 arg #400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next step after #396 is to create an implementation of
StorageApiwhich sends messages from truthsayer to read/write data to archaeologist's storage, similar to how it was showcased in #387. To do this, inputs and outputs of allStorageApihave to be put into a message object, read on the receiving end etc. Writing this messaging code becomes much easier if every API has a signature which follows same structure.This PR changes all signatures to have the structure of "all input values are stored in 1 arg value, with an optional second
AbortSignalarg"